Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented Oct 17, 2025

Summary

This branch makes Vector's internal logging significantly more production-ready by:

  • Preventing log flooding by default (rate limiting ON)
    • todo: remove redundant tags - will followup in another PR
  • Maintaining existing rate limiting behavior
  • Improving developer experience (comprehensive docs + easy opt-out mechanisms)
  • Setting foundation for future improvements

Technically a breaking change but very minor impact.

Vector configuration

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Related: #22410

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront force-pushed the pront-tracing-limit-flag branch from 3882b2c to 762b078 Compare October 17, 2025 21:54
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 17, 2025
@pront pront force-pushed the pront-tracing-limit-flag branch from 762b078 to 1ad0df9 Compare October 17, 2025 22:14
@github-actions github-actions bot added the domain: topology Anything related to Vector's topology code label Oct 17, 2025
@pront pront changed the title feat(internal_logs source): turn ON rate limiting by default feat!(internal_logs source): turn ON rate limiting by default Oct 20, 2025
@pront pront marked this pull request as ready for review October 20, 2025 15:24
@pront pront requested review from a team as code owners October 20, 2025 15:24
Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make life much easier! :)

@buraizu buraizu self-assigned this Oct 20, 2025
@pront pront enabled auto-merge October 20, 2025 19:05
@buraizu buraizu removed their assignment Oct 20, 2025
@pront pront added this pull request to the merge queue Oct 20, 2025
Merged via the queue into master with commit 3146eca Oct 20, 2025
78 checks passed
@pront pront deleted the pront-tracing-limit-flag branch October 20, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: topology Anything related to Vector's topology code no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants